Highlight invalid entries in manual pipeline trigger #4153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6543
added
ui
|
Nice! Can you make it impossible to click the save/confirm button if something is invalid? |
|
Oh! Let me kook |
|
@qwerty287 done |
|
updated video |
qwerty287
approved these changes
Oct 6, 2024
|
we can addopt it more later :) |
no that wont be of use as it is no key value map |
|
Tearing down https://woodpecker-ci-woodpecker-pr-4153.surge.sh |
OK, but we could generalize the editor to have an option "with-keys" or something like this to switch between value only and key-value. But I don't know if these cases are too different to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and move key-value editor into own component
vid-20241006-131241.mp4
picked from #4131